Comments on: Taking on “Testing Triangles – A classic excercise”

By: Venkat Reddy Chintalapudi

Venkat Reddy Chintalapudi — Thu, 29 Mar 2007 16:32:27 +0000

The content of the post has been fine tuned.

By: Venkat Reddy Chintalapudi

Venkat Reddy Chintalapudi — Sun, 25 Mar 2007 06:06:06 +0000

Thanks Elisabeth for pointing to me this exercise.

Simple testing problems like this helps us towards the approach on how you are testing and uncovering the important issues.

Seen many issues on the input validations on your post, but they are secondary.

Interesting bugs here that Application says an invalid triangle as a valid and drawing the same out of the box.

You said it right, “sides = sides.sort();” code like this is very common for the developers to make and miss out the same in code review.

But it’s easy to catch, if the developer starts writing a unit tests for the same.

By: Prasad

Prasad — Sun, 25 Mar 2007 04:58:48 +0000

But original credit for finding the sort bug should go to Mallik of http://codeinspections.blogspot.com since he has posted the issue couple a day before this article. But definitely this article provided additional informtion definitely.

[ Venkat's Reply:
Prasad, mallik is a friend of mine & i have appreciated over the same. My mission here is to the the approach towards testing the same. The more time you to take to explore an issue, will save lot of time for others to understand, debug and fix the same.
]

By: Venkat Reddy Chintalapudi

Venkat Reddy Chintalapudi — Sat, 24 Mar 2007 17:29:26 +0000

Thanks Pradeep for your comments.

My misson out here is to uncover the critical issues of the application as early as passible. This will happen only when we work with the application and improve the undestanding of the same by exploring it’s features.

So this post contains my approch towards testing an application and the same need improvement. I wish i could do that in a betterway.

By: Elisabeth Hendrickson

Elisabeth Hendrickson — Sat, 24 Mar 2007 13:35:32 +0000

Wow, that’s an impressive bit of analysis! I’m particularly impressed that you took the time to find the sort bug that causes all kinds of odd behavior in this little sample. (It’s an example of a subtle mistake that’s easy to make when writing code, hard to spot when reading code, and that can be easy to miss if you only ever try single digit test data.) Excellent work!